logsoftmax with dims #135
Merged
logsoftmax with dims #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
- Coverage 79.03% 77.73% -1.3%
=========================================
Files 24 24
Lines 763 768 +5
=========================================
- Hits 603 597 -6
- Misses 160 171 +11
Continue to review full report at Codecov.
|
|
It would be best to avoid in-place operations, since these are designed to be AD-compatible. Otherwise it looks good. |
|
OK, done. |
|
Perfect, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #77, this adds a version of
logsoftmaxwhich takesdimskeyword, and∇logsoftmaxtoo.It also adjusts the implementation for
softmaxfrom #130 so as not to exponentiate twice; this is about twice as fast, see #77 (comment) .Both of these mutate their
outarray, which could easily be avoided if desired, at the cost of twice the memory.